Saved searches

Use saved searches to filter your results more quickly

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

git-tfs / git-tfs Public

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for TFS code-review workflow #913

support for TFS code-review workflow #913

Comments

An extension to #908

Just a wishlist thing but thought I'd write it down while it was in my head.

I'm currently using git-tfs but having to put every checkin through the review process as enforced by Colin's ALM addon https://visualstudiogallery.msdn.microsoft.com/045730ee-63c0-498e-b972-42b05a2d0857

If you use Visual Studio to create a code review request then behind the scenes it creates a shelveset to use for the review. Handily you can create a review from any shelveset using Visual Studio.

The workflow I'm currently using is

1. Prepare commit in git
2. git tfs shelve some-name -w=1234 to create a shelveset
3. open visual studio, find the shelveset, right-click > "request review"
4. note the id of the code-review e.g. 666
5. amend the commit adding git-tfs-work-item: 666 to the end
6. await glowing praise and a "Finished (Looks Good)" approval
7. close the review (to keep the Colin's ALM happy)
8. get latest, handle conflicts etc, rebase onto tfs/default
9. git tfs rcheckin

I reckon a fair bit of that could be automated by using the TFS APIs.

The text was updated successfully, but these errors were encountered: